diff --git a/src/keepass2android-app/PasswordActivity.cs b/src/keepass2android-app/PasswordActivity.cs index 96c6bd1f..3260cd30 100644 --- a/src/keepass2android-app/PasswordActivity.cs +++ b/src/keepass2android-app/PasswordActivity.cs @@ -1425,18 +1425,20 @@ namespace keepass2android App.Kp2a.SetQuickUnlockEnabled(cbQuickUnlock.Checked); App.Kp2a.ScreenLockWasEnabledWhenOpeningDatabase = (((KeyguardManager)GetSystemService(Context.KeyguardService)!)!).IsDeviceSecure; + App.Kp2a.QuickUnlockBlockedWhenDeviceNotSecureWhenOpeningDatabase = PreferenceManager.GetDefaultSharedPreferences(this) + .GetBoolean(GetString(Resource.String.QuickUnlockBlockedWhenDeviceNotSecure_key), true); - if ((_loadDbFileTask != null) && (App.Kp2a.OfflineMode != _loadDbTaskOffline)) + if ((_loadDbFileTask != null) && (App.Kp2a.OfflineMode != _loadDbTaskOffline)) { - if (App.Kp2a == null) + if (App.Kp2a == null) throw new NullPointerException("App.Kp2a"); //keep the loading result if we loaded in online-mode (now offline) and the task is completed if (!App.Kp2a.OfflineMode || !_loadDbFileTask.IsCompleted) { //discard the pre-loading task - _loadDbFileTask = null; + _loadDbFileTask = null; } - + } //avoid password being visible while loading: diff --git a/src/keepass2android-app/QuickUnlock.cs b/src/keepass2android-app/QuickUnlock.cs index d57fd51f..e4141201 100644 --- a/src/keepass2android-app/QuickUnlock.cs +++ b/src/keepass2android-app/QuickUnlock.cs @@ -178,7 +178,7 @@ namespace keepass2android App.Kp2a.Lock(false); }; - if (App.Kp2a.ScreenLockWasEnabledWhenOpeningDatabase == false) + if (App.Kp2a.ScreenLockWasEnabledWhenOpeningDatabase == false && App.Kp2a.QuickUnlockBlockedWhenDeviceNotSecureWhenOpeningDatabase) { FindViewById(Resource.Id.QuickUnlockForm).Visibility = ViewStates.Gone; FindViewById(Resource.Id.QuickUnlockBlocked).Visibility = ViewStates.Visible; diff --git a/src/keepass2android-app/Resources/layout/QuickUnlock.xml b/src/keepass2android-app/Resources/layout/QuickUnlock.xml index 70bd4b02..e00ce971 100644 --- a/src/keepass2android-app/Resources/layout/QuickUnlock.xml +++ b/src/keepass2android-app/Resources/layout/QuickUnlock.xml @@ -78,11 +78,11 @@ android:paddingLeft="16dp" android:paddingRight="16dp" android:paddingTop="16dp"> - + + + + - - + + diff --git a/src/keepass2android-app/Resources/layout/sftp_credentials.axml b/src/keepass2android-app/Resources/layout/sftp_credentials.axml deleted file mode 100644 index f36879d2..00000000 --- a/src/keepass2android-app/Resources/layout/sftp_credentials.axml +++ /dev/null @@ -1,61 +0,0 @@ - - - - - - - - - - - - \ No newline at end of file diff --git a/src/keepass2android-app/Resources/values/config.xml b/src/keepass2android-app/Resources/values/config.xml index db3582ec..aa4067ba 100644 --- a/src/keepass2android-app/Resources/values/config.xml +++ b/src/keepass2android-app/Resources/values/config.xml @@ -123,6 +123,7 @@ 3 QuickUnlockIconHidden_key QuickUnlockIconHidden16_key + QuickUnlockBlockedWhenDeviceNotSecure_key UsageCount LastInfoVersion diff --git a/src/keepass2android-app/Resources/values/strings.xml b/src/keepass2android-app/Resources/values/strings.xml index 9ee59c17..833450a5 100644 --- a/src/keepass2android-app/Resources/values/strings.xml +++ b/src/keepass2android-app/Resources/values/strings.xml @@ -330,6 +330,8 @@ QuickUnlock unfortunately does not work without displaying a notification icon. Select this option to use a transparent icon. Hide QuickUnlock icon QuickUnlock requires a notification to work properly. Select this option to display a notification without an icon. + Block entering the QuickUnlock key if the device is not secured by screen lock. This prevents shoulder surfing attacks. Only disable this option if you understand the risk. Note that QuickUnlock can still be used with biometrics. + Block QuickUnlock when device is not secure Length of QuickUnlock key Maximum number of characters used as QuickUnlock password. Hide QuickUnlock length diff --git a/src/keepass2android-app/Resources/xml/pref_app_quick_unlock.xml b/src/keepass2android-app/Resources/xml/pref_app_quick_unlock.xml index 5c676c5f..dedab5e0 100644 --- a/src/keepass2android-app/Resources/xml/pref_app_quick_unlock.xml +++ b/src/keepass2android-app/Resources/xml/pref_app_quick_unlock.xml @@ -26,6 +26,14 @@ android:defaultValue="false" android:title="@string/QuickUnlockIconHidden_title" android:key="@string/QuickUnlockIconHidden_key" /> + +