From 7de28c5aba8294b43c5acd3a9e733fd2963d9d09 Mon Sep 17 00:00:00 2001
From: Philipp Crocoll <philipp@crocoll.net>
Date: Mon, 6 Mar 2023 10:26:33 +0100
Subject: [PATCH] add preference to control if autofill view details are
 written to log

---
 src/keepass2android/Resources/values/config.xml          | 1 +
 src/keepass2android/Resources/values/strings.xml         | 3 +++
 src/keepass2android/Resources/xml/preferences.xml        | 9 +++++++++
 .../services/AutofillBase/StructureParser.cs             | 6 ++++--
 4 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/keepass2android/Resources/values/config.xml b/src/keepass2android/Resources/values/config.xml
index 071e9645..b6bc4902 100644
--- a/src/keepass2android/Resources/values/config.xml
+++ b/src/keepass2android/Resources/values/config.xml
@@ -54,6 +54,7 @@
   <string name="AlwaysMergeOnConflict_key">AlwaysMergeOnConflict</string>
   <string name="NoDalVerification_key">NoDalVerification_key</string>
   <string name="InlineSuggestions_key">InlineSuggestions_key</string>
+  <string name="LogAutofillView_key">LogAutofillView_key</string>
   <string name="algorithm_key">algorithm</string>
     <string name="app_key">app</string>
     <string name="app_timeout_key">app_timeout_key</string>
diff --git a/src/keepass2android/Resources/values/strings.xml b/src/keepass2android/Resources/values/strings.xml
index 4a89f257..fa615243 100644
--- a/src/keepass2android/Resources/values/strings.xml
+++ b/src/keepass2android/Resources/values/strings.xml
@@ -332,6 +332,9 @@
 
   <string name="InlineSuggestions_title">Integrate with keyboard</string>
   <string name="InlineSuggestions_summary">Shows the autofill suggestions as inline options in the keyboard (if supported by the input method)</string>
+
+  <string name="LogAutofillView_title">Log autofill view</string>
+  <string name="LogAutofillView_summary">Write details about the autofill view to debug log (if debug logging is enabled). These details can be sent to the developer if autofill does not work as expected.</string>
   <string name="requires_android11">Requires Android 11 or later</string>
 	
 	<string name="kp2a_findUrl">Find password</string>
diff --git a/src/keepass2android/Resources/xml/preferences.xml b/src/keepass2android/Resources/xml/preferences.xml
index c159d477..3b18fd70 100644
--- a/src/keepass2android/Resources/xml/preferences.xml
+++ b/src/keepass2android/Resources/xml/preferences.xml
@@ -454,6 +454,15 @@
        android:title="@string/InlineSuggestions_title"
        android:key="@string/InlineSuggestions_key" />
 
+        <CheckBoxPreference
+          android:enabled="true"
+          android:persistent="true"
+          android:summary="@string/LogAutofillView_summary"
+          android:defaultValue="false"
+          android:title="@string/LogAutofillView_title"
+          android:key="@string/LogAutofillView_key" />
+        
+
         <CheckBoxPreference
           android:enabled="true"
           android:persistent="true"
diff --git a/src/keepass2android/services/AutofillBase/StructureParser.cs b/src/keepass2android/services/AutofillBase/StructureParser.cs
index 932d95ac..51e06ed0 100644
--- a/src/keepass2android/services/AutofillBase/StructureParser.cs
+++ b/src/keepass2android/services/AutofillBase/StructureParser.cs
@@ -3,6 +3,7 @@ using System.Linq;
 
 using Android.App.Assist;
 using Android.Content;
+using Android.Preferences;
 using Android.Views.Autofill;
 using DomainNameParser;
 using Kp2aAutofillParser;
@@ -23,8 +24,8 @@ namespace keepass2android.services.AutofillBase
             InputType = (Kp2aAutofillParser.InputTypes) ((int)viewNode.InputType);
             HtmlInfoTag = viewNode.HtmlInfo?.Tag;
             HtmlInfoTypeAttribute = viewNode.HtmlInfo?.Attributes?.FirstOrDefault(p => p.First?.ToString() == "type")?.Second?.ToString();
-
         }
+
         [JsonIgnore]
         public AssistStructure.ViewNode ViewNode { get; set; }
 
@@ -152,7 +153,8 @@ namespace keepass2android.services.AutofillBase
 		    _context = context;
             _structure = structure;
             AutofillFields = new AutofillFieldMetadataCollection();
-            
+            LogAutofillView = PreferenceManager.GetDefaultSharedPreferences(context).GetBoolean(context.GetString(Resource.String.LogAutofillView_key), false);
+
         }
 
         protected override AutofillTargetId Parse(bool forFill, bool isManualRequest, AutofillView<ViewNodeInputField> autofillView)