qwe/keepass2android
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

replace usage of IoConnectionInfo::GetDisplayName() to avoid passwords (as part of the URL) appearing in logfiles

Browse Source
This commit is contained in:
Philipp Crocoll
2023-11-21 13:31:54 +01:00
parent 2e9400cf4d
commit 6ef8b8fc3b
4 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/KeePassLib2Android/Serialization/FileLock.cs
View File

@@ -185,7 +185,7 @@ namespace KeePassLib.Serialization
byte[] pbFile = StrUtil.Utf8.GetBytes(sb.ToString()); byte[] pbFile = StrUtil.Utf8.GetBytes(sb.ToString());
s = IOConnection.OpenWrite(iocLockFile); s = IOConnection.OpenWrite(iocLockFile);
if(s == null) throw new IOException(iocLockFile.GetDisplayName()); if(s == null) throw new IOException(UrlUtil.GetFileName(iocLockFile.Path));
s.Write(pbFile, 0, pbFile.Length); s.Write(pbFile, 0, pbFile.Length);
} }
finally { if(s != null) s.Close(); } finally { if(s != null) s.Close(); }
@@ -205,7 +205,7 @@ namespace KeePassLib.Serialization
if(lfiEx != null) if(lfiEx != null)
{ {
m_iocLockFile = null; // Otherwise Dispose deletes the existing one m_iocLockFile = null; // Otherwise Dispose deletes the existing one
throw new FileLockException(iocBaseFile.GetDisplayName(), throw new FileLockException(UrlUtil.GetFileName(iocBaseFile.Path),
lfiEx.GetOwner()); lfiEx.GetOwner());
} }

5
src/KeePassLib2Android/Utility/MessageService.cs
View File

@@ -28,6 +28,7 @@ using System.Diagnostics;
using KeePassLib.Resources; using KeePassLib.Resources;
using KeePassLib.Serialization; using KeePassLib.Serialization;
using Android.Webkit;
namespace KeePassLib.Utility namespace KeePassLib.Utility
{ {
@@ -411,7 +412,7 @@ Clipboard.SetText(ObjectsToMessage(vLines, true));*/
public static void ShowLoadWarning(IOConnectionInfo ioConnection, Exception ex) public static void ShowLoadWarning(IOConnectionInfo ioConnection, Exception ex)
{ {
if (ioConnection != null) if (ioConnection != null)
ShowLoadWarning(ioConnection.GetDisplayName(), ex, false); ShowLoadWarning(UrlUtil.GetFileName(ioConnection.Path), ex, false);
else ShowWarning(ex); else ShowWarning(ex);
} }
@@ -444,7 +445,7 @@ Clipboard.SetText(ObjectsToMessage(vLines, true));*/
bool bCorruptionWarning) bool bCorruptionWarning)
{ {
if (ioConnection != null) if (ioConnection != null)
ShowSaveWarning(ioConnection.GetDisplayName(), ex, bCorruptionWarning); ShowSaveWarning(UrlUtil.GetFileName(ioConnection.Path), ex, bCorruptionWarning);
else ShowWarning(ex); else ShowWarning(ex);
} }

7
src/Kp2aBusinessLogic/Io/CachingFileStorage.cs
View File

@@ -124,7 +124,7 @@ namespace keepass2android.Io
&& File.Exists(VersionFilePath(ioc)) && File.Exists(VersionFilePath(ioc))
&& File.Exists(BaseVersionFilePath(ioc)); && File.Exists(BaseVersionFilePath(ioc));
Kp2aLog.Log(ioc.GetDisplayName() + " isCached = " + result); Kp2aLog.Log(GetDisplayName(ioc) + " isCached = " + result);
return result; return result;
} }
@@ -598,13 +598,14 @@ namespace keepass2android.Io
public string GetBaseVersionHash(IOConnectionInfo ioc) public string GetBaseVersionHash(IOConnectionInfo ioc)
{ {
string hash = File.ReadAllText(BaseVersionFilePath(ioc)); string hash = File.ReadAllText(BaseVersionFilePath(ioc));
Kp2aLog.Log(ioc.GetDisplayName() + " baseVersionHash = " + hash); Kp2aLog.Log(GetDisplayName(ioc) + " baseVersionHash = " + hash);
return hash; return hash;
} }
public string GetLocalVersionHash(IOConnectionInfo ioc) public string GetLocalVersionHash(IOConnectionInfo ioc)
{ {
string hash = File.ReadAllText(VersionFilePath(ioc)); string hash = File.ReadAllText(VersionFilePath(ioc));
Kp2aLog.Log(ioc.GetDisplayName() + " localVersionHash = " + hash);
Kp2aLog.Log(GetDisplayName(ioc) + " localVersionHash = " + hash);
return hash; return hash;
} }
public bool HasLocalChanges(IOConnectionInfo ioc) public bool HasLocalChanges(IOConnectionInfo ioc)

2
src/Kp2aBusinessLogic/Io/JavaFileStorage.cs
View File

@@ -348,7 +348,7 @@ namespace keepass2android.Io
} }
catch (Exception e) catch (Exception e)
{ {
throw new Exception("Error finding " + filename + " in " + folderPath.GetDisplayName(), e); throw new Exception("Error finding " + filename + " in " + GetDisplayName(folderPath), e);
} }
} }